Skip to content

Run zig build test in GitHub Actions - #2

Merged
mcaney006 merged 1 commit into
mainfrom
ci-zig-build-test
Nov 18, 2026
Merged

mcaney006 merged 1 commit into
mainfrom
ci-zig-build-test

Conversation

@mcaney006

@mcaney006 mcaney006 commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Adds .github/workflows/ci.yml: zig build test --summary all with Zig 0.17.1 on ubuntu-latest and macos-latest, on every pull request and every push to main.

  • actions/checkout v7.0.1 and mlugg/setup-zig v2.2.1 are pinned to commit SHAs.
  • permissions: contents: read, persist-credentials: false, a 20-minute timeout, and superseded runs are cancelled.
  • The Docker labs and benchmarks need root inside containers and stay local; the README says so.

Note

Low Risk
Adds documentation and CI-only workflow with read permissions; no application or security logic changes.

Overview
Adds GitHub Actions CI via .github/workflows/ci.yml that runs zig build test --summary all with Zig 0.17.1 on ubuntu-latest and macos-latest for every pull request and push to main.

The workflow uses pinned action SHAs (checkout v7.0.1, mlugg/setup-zig v2.2.1), read-only contents permissions, persist-credentials: false, a 20-minute job timeout, and concurrency so newer runs on the same ref cancel in-flight ones. The matrix does not use fail-fast, so one OS failing does not skip the other.

The README now states that unit/simulation tests run in CI while Docker-based labs and benchmarks remain local-only (they need root inside containers).

Reviewed by Cursor Bugbot for commit 1f38adf. Configure here.


Devin Review

Runs on pull requests and pushes to main with Zig 0.17.1. Actions are
pinned to commit SHAs, the token is read-only, and checkout does not
keep credentials. The Docker labs still run locally.
@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: 1f38adf7473d26938ea59d97d7f3acc5de427818

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 2 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: 1f38adf7473d26938ea59d97d7f3acc5de427818

PR taxonomy review recommended (neutral)

Detected 2 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation.

Scanned 2 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

  • 1 security-sensitive path(s) changed

Paths:

  • .github/workflows/ci.yml

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • CI workflow changes may ship without failure-mode evidence
  • Dependency or CI drift could surface after merge
  • 1 CI or workflow path(s) changed

Paths:

  • .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: 1f38adf7473d26938ea59d97d7f3acc5de427818

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 2 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: 1f38adf7473d26938ea59d97d7f3acc5de427818

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 2 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T05:23:59.419473Z 1f38adf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Config Audit

Commit: 1f38adf7473d26938ea59d97d7f3acc5de427818

No changed-config issues detected (success)

Scanned 1 config file(s) present at this commit across 1 changed config path(s) and found no issues in the supported security rules.

Changed config files:

  • .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Purpose
The change adds automated build and unit-test coverage for pull requests and pushes to main. It runs the Zig test suite on Linux and macOS. Docker-based labs and benchmarks stay outside CI because they need Docker and root inside containers.

Material changes

  • New workflow .github/workflows/ci.yml named CI:
    • Triggers: push to main and every pull_request.
    • Job test runs on a matrix of ubuntu-latest and macos-latest with fail-fast: false.
    • Runs zig build test --summary all with Zig 0.17.1 (installed by mlugg/setup-zig v2.2.1, pinned to commit d1434d08867e3ee9daa34448df10607b98908d29).
    • Checkout uses actions/checkout v7.0.1, pinned to commit 3d3c42e5aac5ba805825da76410c181273ba90b1, with persist-credentials: false.
    • Workflow token permission is contents: read.
    • Concurrency group ci-${{ github.ref }} with cancel-in-progress: true.
    • Job timeout is 20 minutes.
  • README.md: adds a paragraph (+5 lines) stating that CI runs zig build test on Linux and macOS. It also states that labs and benchmarks run locally because they need Docker and root in containers. No code or runtime behavior changes.

Execution flow
Trigger (push to main or pull request) → GitHub schedules two matrix jobs → each job checks out the repository without persisted credentials → installs Zig 0.17.1 → runs zig build test --summary all → job result is reported. A newer run for the same ref cancels an in-progress run. Labs and benchmarks are not part of this flow.

Risk assessment

Category Rating Rationale
Correctness Low The workflow runs one existing build step. Test results depend on the existing build.zig test targets, which this PR does not change.
Memory safety and undefined behavior Not applicable No Zig source changes.
Concurrency and synchronization Low Concurrency group cancels superseded runs on the same ref. Runs for main pushes can cancel each other, so a newer push can cancel an earlier run's result.
Security and credential handling Low Read-only token permission. Checkout does not persist credentials. Actions are pinned to full commit SHAs. The setup-zig action is third-party and pinned by SHA only; its tag is not verified in this review.
Performance and resource usage Low Two hosted runners per trigger, 20-minute cap per job. Zig installation runs on each job.
Reliability and recovery Low The timeout bounds hung jobs. fail-fast: false keeps both matrix results. No retry logic. Hosted-runner availability can cause failures unrelated to code.
Backward compatibility Low No existing interfaces or build outputs change. The workflow file is new.
Deployment and rollback Low Rollback is deleting or disabling the workflow file. No production deployment is involved.

Validation

  • The PR diff was checked against the merge base 85d612023f8f448cd4531bd02f7a09ca1f8730a4. It changes two files with 36 insertions and no deletions. The contents of ci.yml and the README change match the PR description.
  • No CI run results for this PR are in the supplied evidence. Whether zig build test --summary all passes on either runner is not available.
  • Not available: evidence that Zig 0.17.1 is a released version that mlugg/setup-zig v2.2.1 supports; evidence that the pinned commit SHAs match the cited tags; any local or sanitizer run.
  • The workflow does not run Zig's build with sanitizers, static analysis, or hardware tests. The labs and benchmarks, which need Docker and root, are not covered by CI.

Operational impact

  • Configuration: none at runtime. The workflow requires GitHub Actions to be enabled for the repository.
  • Environment variables, IAM requirements, filesystem changes, schema changes, hardware assumptions, and migration steps: none in this PR.
  • Network requirements: the runner must reach GitHub, the Zig toolchain download source used by setup-zig, and the Actions artifacts/cache backend. The pinned actions are downloaded at run time.
  • Rollback: remove .github/workflows/ci.yml and revert the README paragraph.
  • Repository policy: if branch protection requires these checks, the job names zig build test (ubuntu-latest) and zig build test (macos-latest) must be added as required checks. That step is outside this PR.

Adds a GitHub Actions workflow that runs zig build test --summary all on Ubuntu and macOS for pushes to main and pull requests. The README describes the CI runs and notes that labs and benchmarks run locally.

Changes: CI Test Workflow

Layer / File(s) Summary
Configure and document CI tests
.github/workflows/ci.yml, README.md
The workflow configures triggers, read-only contents permission, concurrency cancellation, and an Ubuntu and macOS test matrix. It checks out the repository, installs Zig 0.17.1, and runs zig build test --summary all. The README describes the CI runs and notes that labs and benchmarks run locally.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 1f38a

This adds CI test runs on Linux and macOS for pull requests and pushes to main. It does not change runtime behavior. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: the PR adds a GitHub Actions job that runs zig build test. The workflow file ci.yml matches this. The title is concise and specific.
Description check Passed The description states the workflow file, the zig build test command, the Zig version, the runners, the triggers, the pinned actions, the permissions, the timeout, and the README note on local Docker …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description states the workflow file, the zig build test command, the Zig version, the runners, the triggers, the pinned actions, the permissions, the timeout, and the README note on local Docker labs. All of these match the changeset summary.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

The matrix wakes on Linux and Mac,
Zig checks the build, then sends it back.
A pinned action turns the key,
Tests run in orderly machinery.
Labs wait where Docker roots can roam.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 188ca44c-93b6-458f-8ea7-11fff447d3c4
Commits

Reviewing files that changed from the base of the PR and between 85d6120 and 1f38adf.

Files selected for processing: 2

  • .github/workflows/ci.yml
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 5

  • GitHub Check: Cursor Bugbot
  • GitHub Check: Gitar
  • GitHub Check: zig build test (ubuntu-latest)
  • GitHub Check: zig build test (macos-latest)
  • GitHub Check: Repowise review

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Harness Audit

Commit: 1f38adf7473d26938ea59d97d7f3acc5de427818

No harness issues detected (success)

Scanned 1 changed config file(s) and found no harness issues.

Changed config files:

  • .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@gitar-bot

gitar-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@mcaney006
mcaney006 merged commit 0a4df6a into main Nov 18, 2026
9 checks passed
@mcaney006
mcaney006 deleted the ci-zig-build-test branch November 18, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant